search

webmozarts / glob

A PHP implementation of Ant's glob.
MIT License
253 stars 16 forks source link

Replaced `webmozart/path-util` dependency with `@internal` `Path::isAbsolute()` #60

Closed Ocramius closed 2 years ago

Ocramius commented 2 years ago

This imports sources from webmozart/path-util: since the license and authors are the same, no further license additions are necessary.

Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/tests/PathTest.php Ref: https://github.com/webmozart/path-util/blob/6099b5238073f87f246863fd58c2e447acfc0d24/src/Path.php

Fixes #59 Fixes #57

Ocramius commented 2 years ago

Interesting: tests failing on windows due to the phpvfscomposer:// stuff :thinking:

Really annoying overall - composer replacing everything is getting really painful.

Nek- commented 2 years ago

Nice one. I'm fine with it, just some notice you may want to take a look at. But you can merge it. Thank you very much @Ocramius .

Ocramius commented 2 years ago

I'll roll it as-is (in a release) for now: #28 should highlight these redundant casts in future, and we can adapt there 👍

Ocramius commented 2 years ago

Thanks for the review, @Nek-!

williamdes commented 2 years ago

Hi @Ocramius A nice PR! Can someone archive the path util repo?