search

webmproject / sjpeg

SimpleJPEG: simple jpeg encoder
Apache License 2.0
72 stars 13 forks source link

cmake/android.cmake file is missing #111

Closed EwoutH closed 3 years ago

EwoutH commented 3 years ago

I'm currently trying to build for Android. According to the Readme there should be a file android.cmake in the cmake directory, but that one seems to be missing.

skal65535 commented 3 years ago

On Thu, Apr 22, 2021 at 6:24 PM Ewout ter Hoeven @.***> wrote:

I'm currently trying to build for Android. According to the Readme https://github.com/webmproject/sjpeg#compiling-with-android-ndk there should be a file android.cmake in the cmake directory, but that one seems to be missing.

Yes, it was missing from pull request #107 https://github.com/webmproject/sjpeg/pull/107, i'm fixing this right now (along with few other missing things)

thanks! skal/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/webmproject/sjpeg/issues/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQIPFZZ7RDITVCZF2YZW7TTKBEUDANCNFSM43MZYXPQ .

skal65535 commented 3 years ago

Hi,

On Thu, Apr 22, 2021 at 6:30 PM Pascal Massimino @.***> wrote:

On Thu, Apr 22, 2021 at 6:24 PM Ewout ter Hoeven @.***> wrote:

I'm currently trying to build for Android. According to the Readme https://github.com/webmproject/sjpeg#compiling-with-android-ndk there should be a file android.cmake in the cmake directory, but that one seems to be missing.

Yes, it was missing from pull request #107 https://github.com/webmproject/sjpeg/pull/107, i'm fixing this right now (along with few other missing things)

should be ok now, with #112 https://github.com/webmproject/sjpeg/pull/112. Sorry about that!

skal/

thanks! skal/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/webmproject/sjpeg/issues/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQIPFZZ7RDITVCZF2YZW7TTKBEUDANCNFSM43MZYXPQ .

EwoutH commented 3 years ago

Thanks a lot for the quick fix! It now successfully builds on my CI configuration, for which I added a PR with #113.