search

webmproject / sjpeg

SimpleJPEG: simple jpeg encoder
Apache License 2.0
69 stars 12 forks source link

Move cmake files from datadir to libdir #115

Open eclipseo opened 3 years ago

eclipseo commented 3 years ago

Current location is preventing me to detect it correctly.

eclipseo commented 3 years ago

It might be specific to my build setup: I use RPM to build a package and it detects the cmake folder automatically in lib64/cmake and thus adds an automatic Provides: cmake(nameofthelibrary) to be called from other packages depending on it. But it does not work in /usr/share. This is pretty distribution specific so I can keep my patch downstream and close this PR if it's ok.

jzern commented 3 years ago

Thanks for the background. It looks like there isn't a canonical location for these though the cmake docs use lib/ in their current examples [1]. Out of curiosity do any of the other forms work like changing sjpeg/cmake to cmake/sjpeg under /usr/share?

[1] https://cmake.org/cmake/help/v3.20/manual/cmake-packages.7.html?highlight=configpackagelocation#creating-packages

eclipseo commented 3 years ago

I've tested cmake/sjpeg under /usr/share and it works. I don't know the list or all working pattern, nor how they are detected by RPM.

jzern commented 3 years ago

Thanks for trying it out. I'll let Pascal comment, but staying with /usr/share is fine to me.

skal65535 commented 3 years ago

thanks for trying both solutions. If they are both working and allowed, let's just keep it as is, to minimize disruption!