search

webodf / ViewerJS

ViewerJS: Document Reader in JavaScript
http://viewerjs.org
1.94k stars 419 forks source link

Allow to specify the version of WebODF and PDF.js uses by cmake parameters #144

Open vielmetti opened 9 years ago

vielmetti commented 9 years ago

This pull request https://github.com/kogmbh/ViewerJS/pull/143 advances the version of PDF.js to the latest release (1.1.1), from 1.0.1040.

Alternatively, I'd think that it would be a useful addition to the build instructions to be able to specify a specific version of PDF.js to build, though I don't know the cmake incantation to make that happen.

kossebau commented 9 years ago

Might be an option to allow to specify the version used. Perhaps once somebody finds time to do a patch. But then the API of WebODF and PFD.js is not really stable, so too much variability here is not really possible. Keeping as wish for now :)

vielmetti commented 9 years ago

Thanks @kossebau . The issue I'm up against is that PDF.js doesn't render some of the documents I have neatly at 1.0.1040 but apparently does work at 1.1.latest. If you can help me sort through the relevant bits of the API that I might need to look for I will try to help.

vielmetti commented 9 years ago

Thanks again @kossebau . I found a particular upstream bug in Chrome (!) that affects a particular document I'm looking to render, and if that's resolved in Chrome then picking a PDF.js version won't be on the critical path, making this enhancement low priority.

vielmetti commented 9 years ago

The upstream Chrome bug has been fixed at https://code.google.com/p/chromium/issues/detail?id=488103