search

webonyx / graphql-php

PHP implementation of the GraphQL specification based on the reference implementation in JavaScript
https://webonyx.github.io/graphql-php
MIT License
4.63k stars 561 forks source link

amphp/amp v3 compatibility #1474

Open abdullahseba opened 10 months ago

abdullahseba commented 10 months ago

The bundled AMP PHP adaptor is not compatible with APM V3 and causes an error when used. Amp server is listed as a dev dependency so maybe it should be version-locked until this is fixed?

spawnia commented 9 months ago

What is APM V3?

abdullahseba commented 9 months ago

Sorry, AMP v3*

spawnia commented 9 months ago

See https://github.com/webonyx/graphql-php/pull/1262#issuecomment-1427737342.

abdullahseba commented 8 months ago

If it's not being done now, the version should be locked to 2.x in composer.json?

spawnia commented 8 months ago

No, as it is an optional dependency.