webos-internals / meta-doctor

The Meta-Doctor is a Makefile which can modify a copy of the Palm webOS Doctor before it is flashed onto a webOS device. It accomplishes this by reaching into Palm's distributed Doctor JAR file and making changes to it.
http://www.webos-internals.org/wiki/Application:MetaDoctor
35 stars 18 forks source link

Added AT&T PrePlus 2.2.4 script to meta-doctor list... #31

Closed jdsenter closed 12 years ago

rwhitby commented 12 years ago

It would be good to check that the expected binary values are in the expected place in novacomd and jailer before replacing them, just as a safety check.

jdsenter commented 12 years ago

The files are extracted from the webOS 2.2.4 source just before modification, I guess I could md5sum them before and after to validate the pre and post condition and if they fail compare of the md5sum then I could stop the script at that time, but assume (I hate doing that) the files will be valid. I also assume, that if the files failed to alter they stay roadrunner, which is what they were prior to the build change to alter these... Also was thinking what if the DD (process I use to alter the string) utility used on other PC's would produce a different md5sum hash, I assume it would not, as I already know the MAC version of DD understands hex and another only understood decimal for the location of the string to be altered. If you have an alternative method I would love to know what you are thinking?

rwhitby commented 12 years ago

I guess I'm thinking of the case in the future when a new doctor is released for something, and someone updates this script, and forgets that those offsets refer to specific bytes being changed in the binaries.

No, I don't have any solutions, just concerns :-)