search

webosbrew / apps-repo

Central repo for webOS Homebrew apps
Apache License 2.0
53 stars 31 forks source link

Aerial screensaver for webOS #103

Closed aabytt closed 4 months ago

github-actions[bot] commented 4 months ago

Check Results for webos.custom-screensaver-aerial.yml:

Package Metadata

:white_check_mark: Check passed.

Compatibility Check

App webos.custom-screensaver-aerial

Skip because this component is not native

All OK

mariotaku commented 4 months ago

Hi @aabytt, thanks for the submission. There are a few things I'm concerned about:

  1. I think it's better to use your own package name prefix instead of org.webosbrew.
  2. Since the resources are linking to non-free resources, this app may better suit in non-free pool.
aabytt commented 4 months ago
  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Sure, will do

  1. Since the resources are linking to non-free resources, this app may better suit in non-free pool.

Could not find whether linked resources are non-free. Many github screensaver projects use them. Do you think it is better to unlink the app and resources leaving a user possibility to download resources with own link?

mariotaku commented 4 months ago

Oh I see! The assets are externally linked so the second concern isn't a problem anymore :)

aabytt commented 4 months ago
  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Hey @mariotaku, prefix changed

mariotaku commented 4 months ago

Thanks. Very cool app!

mariotaku commented 4 months ago

P.S. Could you add some screenshot to the descriptions? It looks very cool and would be better if the users can see it in the descriptions.

aabytt commented 4 months ago

To add screenshots I need to PR an updated .yml file, right?

mariotaku commented 4 months ago

@aabytt Yes, exactly. Also I could help you make the update.