search

webosbrew / youtube-webos

YouTube app for webOS without ads
GNU General Public License v3.0
594 stars 42 forks source link

Bug: Syntax error on webOS 3.0 #151

Closed throwaway96 closed 7 months ago

throwaway96 commented 8 months ago

See webosbrew/webos-homebrew-channel#179 (here).

jospezial commented 8 months ago

The non working green button and no adblock in videos is since https://github.com/webosbrew/youtube-webos/releases/tag/v0.3.3-rc1 That works in https://github.com/webosbrew/youtube-webos/releases/tag/v0.3.2

throwaway96 commented 8 months ago

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

fire332 commented 8 months ago

@throwaway96 To reply to your comment here, the updates to some babel dependencies could be related but that's all I got. Have you looked at the diff to see where it's erroring?

jospezial commented 8 months ago

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

adblock works again when playing videos. Can navigate in adblock menu but checkboxes don't change with "OK" -key.

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus? Up/down moved through video tiles behind the adblock menu.

fire332 commented 8 months ago

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus? Up/down moved through video tiles behind the adblock menu.

I've noticed this too on my C1 on my branch. I have to wait a little bit after opening the config menu before pressing up/down to navigate through the config menu or the focus will still be in youtube for some reason.

cremor commented 8 months ago

Can navigate in adblock menu but checkboxes don't change with "OK" -key.

Maybe related to #143?

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus? Up/down moved through video tiles behind the adblock menu.

This is not a new problem, I've already seen this in older verisons. Just close and open the settings again and it should work.

igorkulman commented 7 months ago

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

I can confirm this also works for me.

throwaway96 commented 7 months ago

@cremor

This is not a new problem, I've already seen this in older verisons. Just close and open the settings again and it should work.

Did you have this problem in 0.3.1 or older?

(I just got it to happen on 0.3.1. So... not my fault! Opened issue #157 to track.)

cremor commented 7 months ago

Did you have this problem in 0.3.1 or older?

0.3.1 was the current version when I started to use the app, and it was the version where I noticed it first.

Meth69 commented 7 months ago

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

I'm on webOS 3.9.0 and can confirm the 0.3.4-dev1 works, whereas 0.3.3 didn't open the settings menu and didn't block ads.

throwaway96 commented 7 months ago

Should be fixed as a side effect of #146.

Please try 0.3.4-rc1.

jospezial commented 7 months ago

0.3.4-rc1

Can navigate in adblock menu but checkboxes don't change with "OK" -key. The adblock menu window still looses focus and then remote control controls youtube in background.

throwaway96 commented 7 months ago

@jospezial

See #157.

throwaway96 commented 7 months ago

Well, this has been fixed at least. Ugh.