search

webosbrew / youtube-webos

YouTube app for webOS without ads
GNU General Public License v3.0
491 stars 39 forks source link

SponsorBlock segments not rendered on videos with chapters #8

Open Informatic opened 2 years ago

Informatic commented 2 years ago

Seems like chapters have just been rolled out to YouTube TV. This causes our SponsorBlock segments rendering to break.

Skips are properly executed.

Test video: https://www.youtube.com/watch?v=R3iNAQqqnjE Screen capture

Informatic commented 2 years ago

New slider class: .ytlr-multi-markers-player-bar-renderer slider

Informatic commented 2 years ago

Another issue: original slider is replaced with segmented one fairly randomly - we now also need to watch for slider removal in parent node. Whoops.

LuminescentMoon commented 2 years ago

Just an update on this: I've made a quick preact component a while back that emulates the rect and opacity/visibility of a unmanaged element in a managed element which would allow having the sponsorblock overlay "in" the slider while being out of YT's VDOM. The only reason I haven't made a pull request with it is because I had trouble emulating the proper stacking context which means the sponsorblock overlay would not be behind certain elements as it should be, causing minor visual bugs.

Just ping me if you want the code for it as I'm busy with other stuff.