search

webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Support ares-log #27

Closed ssuminahn closed 3 years ago

ssuminahn commented 3 years ago

:Release Notes: Support ares-log

:Detailed Notes: ares-log provides the user with a more convenient function to check the log. Most of the options provided by the existing journald can be utilized. In addition, it provides a function to save log, search log file list, and search unit list.

:Testing Performed:

  1. Pass unit test on ose and auto
  2. Pass eslint
  3. Check below options
    • node ares-log.js -sd pmlogd
    • node ares-log.js -cd
    • node ares-log.js -f
    • node ares-log.js -r
    • node ares-log.js -n 7
    • node ares-log.js -k
    • node ares-log.js -b
    • node ares-log.js -S today
    • node ares-log.js -U yesterday
    • node ares-log.js -S 2021-04-07 21:45:00 --until 2021-04-07 21:46:00
    • node ares-log.js -f -pid 1834
    • node ares-log.js -f -o json
    • node ares-log.js -n 7 -s
    • node ares-log.js -f -s
    • node ares-log.js -s tmp.log
    • node ares-log.js -s tmp
    • node ares-log.js -f -o -d ose
    • node ares-log.js -f -o jjson -d ose
    • node ares-log.js --file-list
    • node ares-log.js --file system.journal
    • node ares-log.js -ul
    • node ares-log.js -ul -dp 1
    • node ares-log.js -u com.webos.service.position -d auto
    • node ares-log.js -u sam -dp 1 -f -d auto

:Issues Addressed: [PLAT-134677] Support to unit test of ares-log

ssuminahn commented 3 years ago

@YoungeunKim This review request is in progress. The bug or code may not be perfect yet. Please consider and review. If you find any bugs, please leave a comment on the ongoing jira task.

YoungeunKim commented 3 years ago

@ssuminahn , Verified ares-log options execution and reviewed code. It seems that there are bugs, but I expect that you will fix it. If you run "eslint", it helps you code clean up. Please add TCs including several negative cases, ares-log -h and rebase develop branch.

Please continue your work. I'll comment for details for your activated RP.

ssuminahn commented 3 years ago

code :+1: verify :+1:

I will update the help file of ares-log

ssuminahn commented 3 years ago

This PR has been replaced by https://github.com/webosose/ares-cli/pull/31. I close this PR.