webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Add empty session tips for Auto #37

Closed YoungeunKim closed 3 years ago

YoungeunKim commented 3 years ago

:Release Notes: Add empty session tips for Auto

:Detailed Notes: After flashing booting, user should select "profile icon" on the screen. At this time, the session list is empty. So, CLI commands print unexpected results. Add tips message to user

:Testing Performed:

  1. Before run TC, you must select a profile on each display. TC passed on AUTO & OSE target and Auto emulator.
  2. eslint passed
  3. Verified with CLI commands a. boot Auto board. The login UI is shown b. Run CLI commands. "select profile" tips should be printed.
    $ ./ares-install.js com.domain.app_1.0.0_all.ipk 
    $ ./ares-launch.js -r
    $ ./ares-launch.js -H sampleWeb
    $ ./ares-launch.js -c com.test.app
    $ ./ares-device.js -s
    $ ./ares-inspect.js -s com.domian.app.test
    $ ./ares-install.js -l
    $ ./ares-install.js -F
    $ ./ares-shell.js -dp 1
    $ ./ares-log.js -ul -dp 1 (on Auto target)
    > ares-xxxx ERR! [Tips]: Please select the profile on the display

:Issues Addressed: [PLAT-143757] Add "login profile" tips after flash booting

YoungeunKim commented 3 years ago

Code :+1: Verified :+1:

YoungeunKim commented 3 years ago
  1. In case emulator user is developer, "$ ./ares-log.js -ul -dp 1" is displayed "ares-log ERR! [Tips]: Unable to connect to the target device. root access required". Is this your intention? I think this is okay. I'm asking for confirmation.
  2. On Test performed, #1 is needed more explanation. For example, Before test run, you must select a profile each display. Pass TC~~

Answers :

  1. Yes. At first, ares-log checks root permission and then sessionlist for -dp 1. So, "Unable to connect to the target device. root access required" is expected Tips
  2. I updated it.
YoungeunKim commented 3 years ago

Code 👍 Verified 👍

ssuminahn commented 3 years ago

code :+1: verify :+1: