search

webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Fix_callback_bug_in_ares-package #50

Closed ssuminahn closed 3 years ago

ssuminahn commented 3 years ago

:Release Notes: Fix_callback_bug_in_ares-package

:Detailed Notes: Correct the mistakes made in the static analysis process

:Testing Performed:

  1. Pass unit test on ose
  2. Pass eslint
  3. Check corrected code and the data value. To verify, index.html, appinfo.json, and icon.png should also be under the resources directory in the webapp directory.

:Issues Addressed: [WRN-2919] Fix callback bug in ares-package

YoungeunKim commented 3 years ago

@ssuminahn , I added console as the below code

rewriteFileWoBOMAsUtf8(filePath, true, function(err, data) {
console.log(data);

However, the log is not shown when I execute "ares-package sampleApp". Please let me know that if there is precondition or an app for this test.

YoungeunKim commented 3 years ago

Code 👍 Verified 👍