webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Support info and info-detail options on ares-package #61

Closed ssuminahn closed 2 years ago

ssuminahn commented 2 years ago

:Release Notes: Support info and info-detail options on ares-package

:Detailed Notes:

:Testing Performed:

  1. Pass unit test on linux and windows
  2. Pass eslint
  3. Before run unit test, run "npm install"
  4. Check outputs below commands
    • ares-package -i spec/tempFiles/ipks/com.web.app_1.0.0_all.ipk
    • ares-package -i spec/tempFiles/ipks/com.sample.echo_0.0.1_all.ipk
    • ares-package -I spec/tempFiles/ipks/com.web.app_1.0.0_all.ipk
    • ares-package -I spec/tempFiles/ipks/com.sample.echo_0.0.1_all.ipk

:Issues Addressed: [WRN-4395] Implement info-detail option of ares-package [WRN-11266] Implement info option of ares-package

YoungeunKim commented 2 years ago

could you add new line between "main: helloworld_webos_service.js" and "id: com.web.app.service2"?

< Service Information >
id: com.web.app.service
services: [{"name":"com.web.app.service"}]
version: 1.0.0
main: helloworld_webos_service.js 
id: com.web.app.service2
services: [{"name":"com.web.app.service2"}]
version: 1.0.0
main: helloworld_webos_service.js
YoungeunKim commented 2 years ago

code 👎

ssuminahn commented 2 years ago

could you add new line between "main: helloworld_webos_service.js" and "id: com.web.app.service2"?

< Service Information >
id: com.web.app.service
services: [{"name":"com.web.app.service"}]
version: 1.0.0
main: helloworld_webos_service.js 
id: com.web.app.service2
services: [{"name":"com.web.app.service2"}]
version: 1.0.0
main: helloworld_webos_service.js

I've changed this before style.

ssuminahn commented 2 years ago

Verify +1

Please update :

  1. Replace -id to -I in commit message.
  2. There is a format output difference between "services" filed of Package Information and Service Information

I've updated them