webosose / build-webos

webOS OSE build layer
670 stars 126 forks source link

include installation of node version 6.x #4

Closed ric96 closed 6 years ago

ric96 commented 6 years ago

Ubuntu repo has a very old version 4.x This commit allows the script to install a newer 6.x based node and setup node-gyp Test: Builds on Ubuntu 16.04

Signed-off-by: Sahaj Sarup sahaj.sarup@linaro.org

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ericblade commented 6 years ago

My opinion may not mean much here, but 8.x is the current LTS on Node, so that might be a good idea. I'll let the project maintainers debate that, though, just a suggestion. :-)

ric96 commented 6 years ago

@ericblade The build system seems to be downloading 6.x And I do not remember the exact build error but it was something like: file not found: /home/ric/.node-gyp/6.some_version/filename.gyp

el-gringo commented 6 years ago

After applying your patch, apt cannot find node-gyp-install

If the build system download its own node version, what is the point of installing the debian one ?

ric96 commented 6 years ago

@el-gringo without the patch the build fails

el-gringo commented 6 years ago

after the patch scripts/prerequisites.sh fails complaining it cannot find package node-gyp-install

ric96 commented 6 years ago

@el-gringo just updated the pr

chbae commented 6 years ago

@ric96 we already know the problem and fixed it internally. We don't prefer to use this approach and will release our change soon.

Thanks for your contribution.

chbae commented 6 years ago

This is fixed in https://github.com/webosose/meta-webosose/commit/c064061e035df9c1ff8a5ac82ccae5be86de997e