Closed boopathi closed 7 years ago
Hi! Is there any interest on this?
Thanks @michael-ciniawsky for fast review :)
I added the semver:major
label to indicate it as a breaking change, but not really important since it will be publish under a new name on npm anyways :)
@boopathi How important is it being able to customize the babel
& babel-preset-minify
version via options
? :) What about a peerDependency
instead?
I started porting parallelization
support for this plugin from uglifyjs-webpack-plugin
and finish it after has PR has landed :D
@michael-ciniawsky let's fix all issues related to cache and parallelization in uglifyjs-webpack-plugin
(and add tests) and we can implement same algorithm here :+1:
@boopathi How important is it being able to customize the babel & babel-preset-minify version via options ? :) What about a peerDependency instead?
I added the semver:major label to indicate it as a breaking change, but not really important since it will be publish under a new name on npm anyways :)
I'll be publishing it as 0.2.0
, to use the same version numbers as babel-minify.
@boopathi need somebody from https://github.com/orgs/webpack-contrib/people who have Owner
:disappointed:
Sry I can't, we are just grunt workers here :D Either set the status: Approved
&& pr: Merge ready
labels or ping either (@)d3viant0ne (@)bebraw (@)TheLarkInn (@)SpaceK33z (@)jhnns (@)sokra to give you the appropiated access since you are lead maintainer here 😛
FYI - You have access to merge, it takes owner level access to override the checks.
I still need permission to push to master for release commits. How are release commits pushed to master in webpack-contrib?
@boopathi Just as a question, the package is released as 0.0.0
is it just for some internal reasons or not stable yet?
The first version will be 0.2.0
- mostly keeping it the same version as babel-minify
(0.2.0)
Codecov Report
67.34% <63.88%> (-7.13%)
Continue to review full report at Codecov.