webpack-contrib / babel-minify-webpack-plugin

[DEPRECATED] Babel Minify Webpack Plugin
MIT License
493 stars 44 forks source link

refactor: rename `babili` to `babel-minify` #55

Closed boopathi closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #55 into master will decrease coverage by 6.91%. The diff coverage is 63.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #55      +/-   ##
=======================================
- Coverage   72.91%   66%   -6.92%     
=======================================
  Files           2     2              
  Lines          48    50       +2     
  Branches       16    17       +1     
=======================================
- Hits           35    33       -2     
- Misses         12    15       +3     
- Partials        1     2       +1
Impacted Files Coverage Δ
src/index.js 67.34% <63.88%> (-7.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0a724c...d788353. Read the comment docs.

pi0 commented 7 years ago

Hi! Is there any interest on this?

pi0 commented 7 years ago

Thanks @michael-ciniawsky for fast review :)

michael-ciniawsky commented 7 years ago

I added the semver:major label to indicate it as a breaking change, but not really important since it will be publish under a new name on npm anyways :)

@boopathi How important is it being able to customize the babel & babel-preset-minify version via options ? :) What about a peerDependency instead?

I started porting parallelization support for this plugin from uglifyjs-webpack-plugin and finish it after has PR has landed :D

alexander-akait commented 7 years ago

@michael-ciniawsky let's fix all issues related to cache and parallelization in uglifyjs-webpack-plugin (and add tests) and we can implement same algorithm here :+1:

boopathi commented 7 years ago

@boopathi How important is it being able to customize the babel & babel-preset-minify version via options ? :) What about a peerDependency instead?

I added the semver:major label to indicate it as a breaking change, but not really important since it will be publish under a new name on npm anyways :)

I'll be publishing it as 0.2.0, to use the same version numbers as babel-minify.

boopathi commented 7 years ago
  1. I don't have permission to merge with failing checks. Can someone merge this?
  2. Can someone give me push access to master to push release commits?
alexander-akait commented 7 years ago

@boopathi need somebody from https://github.com/orgs/webpack-contrib/people who have Owner :disappointed:

michael-ciniawsky commented 7 years ago

Sry I can't, we are just grunt workers here :D Either set the status: Approved && pr: Merge ready labels or ping either (@)d3viant0ne (@)bebraw (@)TheLarkInn (@)SpaceK33z (@)jhnns (@)sokra to give you the appropiated access since you are lead maintainer here 😛

joshwiens commented 7 years ago

FYI - You have access to merge, it takes owner level access to override the checks.

boopathi commented 7 years ago

I still need permission to push to master for release commits. How are release commits pushed to master in webpack-contrib?

pi0 commented 7 years ago

@boopathi Just as a question, the package is released as 0.0.0 is it just for some internal reasons or not stable yet?

boopathi commented 7 years ago

The first version will be 0.2.0 - mostly keeping it the same version as babel-minify(0.2.0)

pi0 commented 7 years ago

OK so will wait for 0.2.0 before integrating with nuxt :)) Thanks for your hard work.