"mangle.exclude" doesn't seem to exclude the namespaces

kettanaito commented 6 years ago

Hi. I'm using the latest version of this package - 0.2.0.

Issue

Providing mangle.exclude doesn't exclude the given class/method names from being mangled.

Minify options

new BabelMinifyPlugin({
      removeConsole: true,
      mangle: {
        topLevel: true,
        exclude: {
          /* I need to preserve the names of the classes listed below */
          'FormProvider': true,
          'Form': true,
          'connectField': true,
          'Condition': true,
          'Field': true
        }
      }
    })

Environment

Node: v6.9.5
OS: MacOS Sierra (10.12.6 (16G29))

Reproduce

Clone/fork my repository.
Checkout to dev/bundle-size branch if not there already.
Run npm run build to build the project in production mode
Examine the output bundle - excluded namespaces are still mangled.

Please help me resolve this issue. Thanks.

alexander-akait commented 6 years ago

@kettanaito Thanks for issue, you just use invalid configuration - use minifyOptions: { ... } for mangle option, see https://github.com/webpack-contrib/babel-minify-webpack-plugin#pluginopts

kettanaito commented 6 years ago

@evilebottnawi thanks for the reply!

TL;DR

Please show me a missing example of how to provide these options using BabelMinifyPlugin. Thanks.

Long version

To be honest, I would like to see at least one working example. Even what you've posted right now doesn't make much sense to me:

Here's how to use the plugin from its README:

new MinifyPlugin(minifyOpts, pluginOpts)

How I'm using it:

new MinifyPlugin({
  removeConsole: true,
  mangle: { ... }
})

You suggest I should use minifyOptions, which I do - that's the Object which the plugin accepts as the first argument, isn't it?

removeConsole and removeDebugger, which are minifyOptions, if I get it correctly, work properly when passed as I am passing them. That makes it valid to assume the first Object is a minifyOptions.

Please, could you clarify this? It feels like there's no clear explanation how to pass those options. Thanks.

P.S. I would be only glad to add the proper example of usage myself as a pull request, only explain it to me please.

alexander-akait commented 6 years ago

@kettanaito sorry, you are right, you have valid config, i reopen issue, but seems it is not related to plugin, we just pass option to babel using babel-preset-minify

kettanaito commented 6 years ago

@evilebottnawi thanks!

Let's address the respective repository then, it seems things are broken. Do you mind doing so? If not, please just direct me what is a proper place to ask.

Regardless, what do you think about adding at least one real-world example to this repo? That would help a lot, from my experience.

alexander-akait commented 6 years ago

@kettanaito agree, PR welcome, many work right now

webpack-contrib / babel-minify-webpack-plugin