webpack-contrib / bundle-loader

Bundle Loader

MIT License

658 stars 59 forks source link

refactor: apply webpack defaults #51

Open joshwiens opened 7 years ago

joshwiens commented 7 years ago

Intended to be merged & released as a part of 1.0.0 on a beta dist-tag once this has been finished and properly tested.

BREAKING CHANGE:

Enforces NodeJS > 4.3 via engines

Closes #43

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a2ddc3e). Click here to learn what that means. The diff coverage is 0%.

@@          Coverage Diff           @@
##             master   #51   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     2           
  Lines             ?    14           
  Branches          ?     4           
======================================
  Hits              ?     0           
  Misses            ?    11           
  Partials          ?     3

Impacted Files	Coverage Δ
src/cjs.js	`0% <0%> (ø)`
src/index.js	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2ddc3e...67f4ea4. Read the comment docs.

michael-ciniawsky commented 7 years ago

We need to be careful with what is exported here aswell as the main part is the named export for the pitching loader export function pitch () {...}, so we better double check :)

joshwiens commented 7 years ago

I was actually just looking at that. iirc etwp is the same way? no?

joshwiens commented 7 years ago

Any way it goes, i'm not merging it. I'll push a beta directly from this branch. I'm not big on majors without a supporting test suite

michael-ciniawsky commented 7 years ago

src/cjs.js

const loader = require('./index');

module.exports = loader.default;
module.exports.pitch = loader.pitch;

? Not 💯 :)

michael-ciniawsky commented 7 years ago

cc @evilebottnawi

joshwiens commented 7 years ago

I'm 90% sure you are right about that

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a2ddc3e). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #51   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?       2           
  Lines             ?      14           
  Branches          ?       4           
========================================
  Hits              ?       0           
  Misses            ?      11           
  Partials          ?       3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2ddc3e...67f4ea4. Read the comment docs.