search

webpack-contrib / cache-loader

[DEPRECATED] Caches the result of following loaders on disk
MIT License
637 stars 51 forks source link

Fix integration between prettier and eslint #85

Closed mistic closed 5 years ago

mistic commented 5 years ago

This fix the integration between prettier and eslint so we can have the prettier errors for source code included in the eslint report errors for a better debugging and development experience.

/CC @evilebottnawi

alexander-akait commented 5 years ago

Don't think this integration better because in future we will use remark for linting markdown and other linters, also eslint prettier it is new abstraction with own problems and bugs, better avoid this

mistic commented 5 years ago

@evilebottnawi then do you know any way to show debug information about the prettier failures only using prettier? Just fail on a file without letting know where is the line with the problem (and actually what is the problem) is not a very good experience

alexander-akait commented 5 years ago

hm, i am using prettier as plugin for IDE, maybe we should improve this in prettier or use --loglevel, agree, let's solve this in future, not high priority right now

mistic commented 5 years ago

@evilebottnawi ok that makes sense, I will close this for now while you work on a fix in the prettier side. Meanwhile I've opened a PR to help minimize the problems