webpack-contrib / cache-loader

[DEPRECATED] Caches the result of following loaders on disk

MIT License

638 stars 51 forks source link

Fix wrong option descriptions #97

Closed apfelbox closed 4 years ago

apfelbox commented 4 years ago

This PR contains a:

[x] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[x] metadata update

Motivation / Use-Case

It seems like the texts were just pasted in the wrong locations.

Breaking Changes

n/a

Additional Info

jsf-clabot commented 4 years ago

All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #97 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files           2        2           
  Lines         142      142           
  Branches       21       21           
=======================================
  Hits          118      118           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3371562...7a2e470. Read the comment docs.

apfelbox commented 4 years ago

Not sure about the build failures – are they related to my change?

apfelbox commented 4 years ago

@evilebottnawi sorry, it took some time until I understood that you meant the test snapshots and not the package-lock file 😅 (didn't have my coffee yet..)

I also fixed the npm audit issues that popped up in the meantime, so the CI should now be green.

apfelbox commented 4 years ago

I split it into two commits, as the npm audit fixes have nothing to do with the other fixes.