webpack-contrib / eslint-loader

[DEPRECATED] A ESlint loader for webpack

MIT License

1.06k stars 121 forks source link

docs: formatting #297

Closed ricardogobbosouza closed 5 years ago

ricardogobbosouza commented 5 years ago

This PR contains a:

[ ] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[x] metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

alexander-akait commented 5 years ago

Feel free to merge when CI will be green

codecov[bot] commented 5 years ago

Codecov Report

Merging #297 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #297   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         134    134           
  Branches       28     28           
=====================================
  Hits          134    134

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 360e69c...d745080. Read the comment docs.

ricardogobbosouza commented 5 years ago

@evilebottnawi I need you to approve to merge Merging can be performed automatically with 1 approving review.

ricardogobbosouza commented 5 years ago

Bug on azure pipelines :disappointed: Stopped on MacOS

ricardogobbosouza commented 5 years ago

@evilebottnawi I can't push to branch master https://github.com/webpack-contrib/eslint-loader/pull/294#issuecomment-534702207

alexander-akait commented 5 years ago

@ricardogobbosouza try again

ricardogobbosouza commented 5 years ago

@evilebottnawi

remote: error: GH006: Protected branch update failed for refs/heads/master. remote: error: Required status check "licence/cla" is expected. At least 1 approving review is required by reviewers with write access. To github.com:webpack-contrib/eslint-loader.git

[new tag] v3.0.1 -> v3.0.1 ! [remote rejected] master -> master (protected branch hook declined) error: failed to push some refs to 'git@github.com:webpack-contrib/eslint-loader.git'

alexander-akait commented 5 years ago

@ricardogobbosouza problem still exists? Looks all fine https://github.com/webpack-contrib/eslint-loader/commits/master

ricardogobbosouza commented 5 years ago

@evilebottnawi yes

alexander-akait commented 5 years ago

@ricardogobbosouza what is email on commit? CLA failed when email is invalid for commit

alexander-akait commented 5 years ago

@ricardogobbosouza try again

ricardogobbosouza commented 5 years ago

@evilebottnawi sorry, its works

alexander-akait commented 5 years ago

Great! Feel free to ping me if you need help with something, you can invite other people as member if you need help from other developers (you have permission), anyway before big release will be great if somebody review your code (like me or other developers from webpack/webpack-contrib)

ricardogobbosouza commented 5 years ago

Ok, thanks