search

webpack-contrib / eslint-loader

[DEPRECATED] A ESlint loader for webpack
MIT License
1.06k stars 121 forks source link

chore: update dependency module object-hash to version 2.0.1 #310

Closed bruceauyeung closed 4 years ago

bruceauyeung commented 4 years ago

This PR contains a:

Motivation / Use-Case

changelog for object-hash 2.0.0

v2.0.0 Only Node.js versions >= 6.0.0 are being tested in CI now. No other breaking changes were introduced.

v2.0.1 fixes: https://github.com/puleos/object-hash/issues/71

what i have done: i am using vue-cli-plugin-electron-builder to build my electron appliaction and using this wonderful lib for logging purpose .

eslint-loader(2.2.1) and winston-daily-rotate-file(4.3.0) use object-hash 1.3.1, but i am stuck by issue https://github.com/puleos/object-hash/issues/71

so i manually replaced node_modules/object-hash/dist/object_hash.js with the latest version(2.0.1) and it works well.

Breaking Changes

Only Node.js versions >= 6.0.0 are being tested in object-hash's CI now, so i think Node.js 6.0.0 or higher version is mandatory, but i'm not sure if this is a breaking change for eslint-loader

Additional Info

jsf-clabot commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #310 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #310   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         137    137           
  Branches       29     29           
=====================================
  Hits          137    137

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2dd8b43...d649936. Read the comment docs.

bruceauyeung commented 4 years ago

i think, the two eslint-loader checks failed because of handbars , not this PR .

image

ricardogobbosouza commented 4 years ago

Updated https://github.com/webpack-contrib/eslint-loader/commit/356c8e24a4cfcd007e9fee434dcfe9cace3bc991