search

webpack-contrib / eslint-webpack-plugin

A ESLint plugin for webpack
MIT License
259 stars 48 forks source link

Update the eslint version to 9 #256

Closed chathurabuddi closed 5 months ago

chathurabuddi commented 6 months ago

Modification Proposal

Please update the eslint version to the latest version (9) as this plugin is incompatible with eslint 9.

Expected Behavior / Situation

Actual Behavior / Situation

Please paste the results of npx webpack-cli info here, and mention other relevant information

kembly commented 6 months ago

Linking as it relates. The extensions needs to be removed from the options for eslint 9 compatibility:

https://github.com/microsoft/vscode-eslint/issues/1823

xavierfoucrier commented 6 months ago

Hello @alexander-akait 👋

Any roadmap for this? Thanks! 😘

ricardogobbosouza commented 6 months ago

Hi @xavierfoucrier It has already been done https://github.com/webpack-contrib/eslint-webpack-plugin/commit/d25e94c90b477d465bf4d7fb6450a9b4ed6936f4

I will release a version soon

xavierfoucrier commented 6 months ago

@ricardogobbosouza 💯 ❤️

alexander-akait commented 6 months ago

@ricardogobbosouza Do you need a help with release?

alexander-akait commented 6 months ago

Also we need revisit old version of eslint (drop some of them) and default Node.js version https://github.com/webpack-contrib/eslint-webpack-plugin/blob/master/package.json#L17 (ideally ">= 18.12.0")

ricardogobbosouza commented 5 months ago

Released v4.2.0

ricardogobbosouza commented 5 months ago

Also we need revisit old version of eslint (drop some of them) and default Node.js version https://github.com/webpack-contrib/eslint-webpack-plugin/blob/master/package.json#L17 (ideally ">= 18.12.0")

I will change it in the next major version

xavierfoucrier commented 5 months ago

Hello @ricardogobbosouza 👋

Unfortunately this release do not seems to meet the new eslint 9 requirements, especially the new configuration file format.

See https://eslint.org/docs/latest/use/migrate-to-9.0.0#flat-config.

I am having a "ERROR in [eslint] No ESLint configuration found" when trying to compile with the plugin in production mode, when I restore the old eslint configuration file it works great.

⚠️ EDIT: ok, after a quick investigation, we have the configType option for that, but by default it's set to eslintrc option, which is now deprecated since ESLint 9... so you should update the documentation accordingly and of course it would have been nice to release a 5.0.0 version instead to mark this as "breaking changes". cc @alexander-akait 🥭

ricardogobbosouza commented 5 months ago

In this version ^4.2.0 only support for eslint 9 was added. Using the eslint 9 flat config will be the default in the next major version