webpack-contrib / file-loader

File Loader
MIT License
1.86k stars 257 forks source link

docs(README): replaced Rule.loader with Rule.use in single loader examples #316

Closed alanyinjs closed 5 years ago

alanyinjs commented 5 years ago

This PR contains a:

Motivation / Use-Case

Ref: issue #314

This PR aims to update the doc to reflect use of Rule.loader and Rule.use in the case of using single (rather than multiple) loaders. This being said, Webpack official docs only deprecated the use of Rule.loaders rather than Rule.loader. In particular, it pointed out that Rule.loader can be used as a shortcut to Rule.use: [ { loader } ] (as seen in the following screenshot): screen shot 2018-12-27 at 10 08 43 pm

However most loaders have updated their docs to consistently use Rule.use rather than Rule.loader even in the case of using a single loader: https://webpack.js.org/loaders/babel-loader/ https://webpack.js.org/loaders/babel-loader/

Breaking Changes

No breaking changes

Additional Info

N/A fixes #314

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

alexander-akait commented 5 years ago

@alanyinjs Thanks for PR, need accept CLA

alexander-akait commented 5 years ago

Also please use commit message not more 72 characters :+1:

alanyinjs commented 5 years ago

@evilebottnawi sorry for the delay. should be good to look at now 😄

alanyinjs commented 5 years ago

Not a problem at all :smile: Thanks for reviewing my PR