webpack-contrib / file-loader

File Loader

MIT License

1.86k stars 257 forks source link

Removed duplicate file .prettierrc #354

Closed smondal closed 4 years ago

smondal commented 4 years ago

This PR contains a:

[ ] bugfix
[ ] new feature
[x] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case

There are two prettier file, So removed the duplicate one.

Breaking Changes

No breaking changes. Just remove duplicate file

Additional Info

jsf-clabot commented 4 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

codecov[bot] commented 4 years ago

Codecov Report

Merging #354 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #354   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
  Branches       13     13           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 190829e...0babb3f. Read the comment docs.

anikethsaha commented 4 years ago

@smondal you need to sign the CLA

smondal commented 4 years ago

@anikethsaha can you please let me know how do I sign the CLA, because If i click on "CLA" link, its open a form but not "submit" option there.

anikethsaha commented 4 years ago

you need to sign in through GitHub and then fill the details and submit

smondal commented 4 years ago

@anikethsaha can you please send me the link from where I can sign in CLA. Because If I click "CLA" link its open "https://cla.js.foundation/webpack-contrib/file-loader?pullRequest=354" but no "submit" button showing.

anikethsaha commented 4 years ago

Did you sign in using github ?

smondal commented 4 years ago

Yes, After sign in below page is showing to me. There is no submit button. Also its showing me "You have sign the CLA"

anikethsaha commented 4 years ago

try closing this PR and reopening this one

smondal commented 4 years ago

Ok, I am closing this pull request and open another one