webpack-contrib / file-loader

File Loader
MIT License
1.86k stars 255 forks source link

fix(schema): added description on esModule #358

Closed smondal closed 4 years ago

smondal commented 4 years ago

This PR contains a:

Motivation / Use-Case

Added 'description' field on esModule option.

Breaking Changes

Additional Info

codecov[bot] commented 4 years ago

Codecov Report

Merging #358 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #358   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
  Branches       13     13           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 190829e...bdcc734. Read the comment docs.

anikethsaha commented 4 years ago

CI is not passing run npm run test locally

I guess is there some security alert, you need to do auditing of the dep

smondal commented 4 years ago

Yes, Its passing everything in locally.

Screen Shot 2019-12-29 at 4 19 05 PM
anikethsaha commented 4 years ago

npm audit ?

smondal commented 4 years ago

There was a security issue on serialize-javascript, fixed this. thanks @anikethsaha

anikethsaha commented 4 years ago

cool 👍