search

webpack-contrib / file-loader

File Loader
MIT License
1.86k stars 255 forks source link

feat: pass immutable info on files #383

Closed bschlenk closed 3 years ago

bschlenk commented 3 years ago

This PR contains a:

Motivation / Use-Case

Passes an immutable flag through assetInfo which other plugins may use.

https://github.com/webpack-contrib/file-loader/issues/382

Breaking Changes

Additional Info

jsf-clabot commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 3 years ago

Codecov Report

Merging #383 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           29        30    +1     
  Branches        12        12           
=========================================
+ Hits            29        30    +1
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 718aef5...0df7818. Read the comment docs.

bschlenk commented 3 years ago

not sure why ModuleConcatenationPlugin test is failing. Source doesn't use the immutable flag, is it unrelated?

alexander-akait commented 3 years ago

I think we should improve test, webpack@5 implements better tree so count of modules can be reduced

alexander-akait commented 3 years ago

I will merge and fix tests after merge