search

webpack-contrib / html-loader

HTML Loader
MIT License
1.16k stars 206 forks source link

Should fastparse be moved into loader-utils? #9

Closed diurnalist closed 9 years ago

diurnalist commented 9 years ago

I'm working on adding some features to handlebars-loader, and one of the things I want to add is the ability to insert requires for static assets w/in the templates, or static assets referenced in helper parameters.

The fastparse library looks like it would do what I need, but I'd rather not straight-up copy it from this repo. It seems like it's generic enough to include in loader utils - what do you think? Or, it could be its own repo. I think parseAttributes is fine to stay in here, though I could also see that moving to loader utils as well. What do you think?

sokra commented 9 years ago

I'll move it into a separate module...

diurnalist commented 9 years ago

Dankeshön :)

sokra commented 9 years ago

Here you are: https://github.com/webpack/fastparse

diurnalist commented 9 years ago

Awesome, thanks for the speedy response!

jhnns commented 9 years ago

Nice! Maybe I'll use this the next time I'm trying to parse stuff with regexes :grin: