webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
317 stars 74 forks source link

refactor: apply webpack-defaults #41

Closed joshwiens closed 7 years ago

joshwiens commented 7 years ago

Note: there is more refactoring that will need to be done here that will be handled when tests are added. A Major needs to be released for a deprecation issue already fixed in master, need the breaking portions of defaults to go in with it.

Intended to be merged & released with fa800c6 as a part of 1.0.0 on a beta dist-tag once this has been finished and properly tested.

Further refactoring is required to align with the defaults eslint configuration.

BREAKING CHANGE:

Enforces NodeJS > 4.3 via engines

joshwiens commented 7 years ago

There in lies the problem, i'm no more familiar with it than you are. For the first pass, the intent was to make as few structural changes as possible while still getting the portions of defaults that require a semver major in place.

If you look at the transpiled output, less the obvious ES module / Import changes the change was kept as minimal as possible.

joshwiens commented 7 years ago

@michael-ciniawsky - Unless you have a strong objection, I'd prefer to leave functionality alone and just get the standards in place along with the breaking change already in master that people are waiting on.

I've tested this as it is manually in consuming projects, should be fine to get into master and out into a beta dist-tag for further testing. @sullenor and I will work out some testing & then try to address the long standing #6 & #16 before pushing an rc for 1.0.0

michael-ciniawsky commented 7 years ago

Nope please go ahead, I will also stop to do any refactorings other then plain webpack-defaults and make separate PR instead afterwards, the other way doesn't work out that well unfortunately 😛

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@89155e1). Click here to learn what that means. The diff coverage is 1.23%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #41   +/-   ##
========================================
  Coverage          ?   1.23%           
========================================
  Files             ?       4           
  Lines             ?      81           
  Branches          ?      23           
========================================
  Hits              ?       1           
  Misses            ?      60           
  Partials          ?      20
Impacted Files Coverage Δ
src/cjs.js 0% <0%> (ø)
src/MakeLocalizeFunction.js 0% <0%> (ø)
src/index.js 0% <0%> (ø)
src/MissingLocalizationError.js 5.55% <5.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89155e1...8b2300f. Read the comment docs.