search

webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
318 stars 74 forks source link

Sullenor/testcases #49

Closed mightyaleksey closed 7 years ago

mightyaleksey commented 7 years ago

I decided to start working on test-coverage improvement. ref: https://github.com/webpack-contrib/i18n-webpack-plugin/pull/42

codecov[bot] commented 7 years ago

Codecov Report

Merging #49 into master will increase coverage by 93.88%. The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #49       +/-   ##
===========================================
+ Coverage    1.23%   95.12%   +93.88%     
===========================================
  Files           4        4               
  Lines          81       82        +1     
  Branches       23       23               
===========================================
+ Hits            1       78       +77     
+ Misses         60        4       -56     
+ Partials       20        0       -20
Impacted Files Coverage Δ
src/MissingLocalizationError.js 100% <100%> (+94.44%) :arrow_up:
src/index.js 94.23% <85.71%> (+94.23%) :arrow_up:
src/MakeLocalizeFunction.js 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da5fa4d...35da3d9. Read the comment docs.

joshwiens commented 7 years ago

I should have some free time this weekend, let me know if you want me to lend a hand.

joshwiens commented 7 years ago

That did the trick for the incremental compilation / test execution along with the vscode Jest plugin freaking out :)

mightyaleksey commented 7 years ago

@d3viant0ne Thank you for the tips. Unfortunately, I don't have much time this weekend to finish the pr, so I decided to focus on the common use cases and would be glad if you can help me with turning the testcases automation into the desired way as in the css-loader :)