search

webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
317 stars 74 forks source link

style: rename params for clearity, update && added comments #66

Closed gandazgul closed 6 years ago

gandazgul commented 6 years ago

Noteable Changes

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 6 years ago

Codecov Report

Merging #66 into master will decrease coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   95.12%   95.06%   -0.07%     
==========================================
  Files           4        4              
  Lines          82       81       -1     
  Branches       23       23              
==========================================
- Hits           78       77       -1     
  Misses          4        4
Impacted Files Coverage Δ
src/MakeLocalizeFunction.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd32318...c5baeea. Read the comment docs.

gandazgul commented 6 years ago

Can we merge this in?