search

webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
318 stars 74 forks source link

refactor: i18n Webpack Plugin Webpack 4.x compatibility #68

Open joshwiens opened 6 years ago

joshwiens commented 6 years ago

BREAKING CHANGE: Sets engines to "node": ">= 6.9.0 || >= 8.9.0" BREAKING CHANGE: Drops support for Webpack v2.x

codecov[bot] commented 6 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files           4        4           
  Lines          81       81           
  Branches       23       23           
=======================================
  Hits           77       77           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c9c7d5...c41c10a. Read the comment docs.

MrStarktastic commented 6 years ago

Any update on when this is gonna be merged into master? I'm asking due to a warning I'm getting when using webpack 4: DeprecationWarning: Tapable.plugin is deprecated. Use new API on.hooksinstead Tracing the deprecation warning shows that it originates from I18nPlugin.apply

mistadikay commented 6 years ago

Guys, do you need any help with this one?

adriangalera commented 6 years ago

waiting for this PR to be merged

codecov[bot] commented 6 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files           4        4           
  Lines          81       81           
  Branches       23       23           
=======================================
  Hits           77       77           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c9c7d5...c41c10a. Read the comment docs.