search

webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
318 stars 74 forks source link

Use webpack 4 hooks #73

Open ooflorent opened 6 years ago

ooflorent commented 6 years ago

Use Tapable API to get rid of deprecation notices. This is a breaking change since this PR drops webpack 3 support.

codecov[bot] commented 6 years ago

Codecov Report

Merging #73 into next will increase coverage by 0.28%. The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #73      +/-   ##
==========================================
+ Coverage   95.06%   95.34%   +0.28%     
==========================================
  Files           4        4              
  Lines          81       86       +5     
  Branches       23       23              
==========================================
+ Hits           77       82       +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 94.73% <95.45%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c41c10a...8a51991. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #73 into next will increase coverage by 0.28%. The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #73      +/-   ##
==========================================
+ Coverage   95.06%   95.34%   +0.28%     
==========================================
  Files           4        4              
  Lines          81       86       +5     
  Branches       23       23              
==========================================
+ Hits           77       82       +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 94.73% <95.45%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c41c10a...8a51991. Read the comment docs.

bloodyowl commented 5 years ago

will this ever be merged?

awmackowiak commented 4 years ago

Hey guys. I have this same question as @bloodyowl . Will this ever be merged?