webpack-contrib / i18n-webpack-plugin

[DEPRECATED] Embed localization into your bundle
MIT License
318 stars 74 forks source link

nested properties support #9

Closed a-wart closed 9 years ago

a-wart commented 9 years ago
{"city_route":
      { "airline": "Fluglinie"}
}
console.log(__('city_route.airline')); // Fluglinie
brandonbloom commented 9 years ago

This assumes that keys are intended to be valid identifiers, but the existing usage supports arbitrary string keys.

antonmedv commented 9 years ago

That's ok. You can use it as you want.

antonmedv commented 9 years ago

ping @sokra

sokra commented 9 years ago

This would be a breaking change. It's propably better to make this opt-in.

Try the change the signature of the plugin to Plugin(localization, options) (plus backward-compatiblility) and add an nested property.

vinkla commented 9 years ago

:+1: on adding support for nested values.

ronkorving commented 9 years ago

:+1: from me too. I really wanna use this plugin, but it seems rather... dead and missing some key features. Should I roll my own, or is this coming back to life any time soon? :)

antonmedv commented 9 years ago

@wart what about PR?

a-wart commented 9 years ago

coming soon guys, just couple of days:)

ronkorving commented 9 years ago

I feel like a kid in a candy store 😊

a-wart commented 9 years ago

@sokra I updated PR, check it please

a-wart commented 9 years ago

@sokra , updated

scythargon commented 9 years ago

@sokra

sokra commented 9 years ago

Thanks

ronkorving commented 9 years ago

@sokra and thank you!