search

webpack-contrib / imports-loader

Imports Loader
MIT License
520 stars 63 forks source link

Allow setting dot-prop values instead of variables #35

Closed niksy closed 7 years ago

niksy commented 7 years ago

This allows to e.g. use window properties.

This PR contains adjustments for https://github.com/webpack/imports-loader/pull/21.

jsf-clabot commented 7 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

SpaceK33z commented 7 years ago

Note that #30 looks a lot like this PR, but has tests.

niksy commented 7 years ago

@SpaceK33z huh, you’re right. I was thinking of writing tests, but I’m not familiar with infrastructure used for that in loaders. I guess this PR can be closed and conversation continued in that PR?

SpaceK33z commented 7 years ago

Jep. Sorry for the trouble, I hadn't seen that PR earlier. We're all very busy with the webpack v2 release, but I'll put #30 on my todo list to review.

SpaceK33z commented 7 years ago

@niksy, might be of interest for you: imports-loader@0.7.0 was just released with #30.