Closed niksy closed 7 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Note that #30 looks a lot like this PR, but has tests.
@SpaceK33z huh, you’re right. I was thinking of writing tests, but I’m not familiar with infrastructure used for that in loaders. I guess this PR can be closed and conversation continued in that PR?
Jep. Sorry for the trouble, I hadn't seen that PR earlier. We're all very busy with the webpack v2 release, but I'll put #30 on my todo list to review.
@niksy, might be of interest for you: imports-loader@0.7.0
was just released with #30.
This allows to e.g. use
window
properties.This PR contains adjustments for https://github.com/webpack/imports-loader/pull/21.