search

webpack-contrib / istanbul-instrumenter-loader

Istanbul Instrumenter Loader
MIT License
273 stars 65 forks source link

strange bug I just can pin a description to #38

Closed shlomiassaf closed 7 years ago

shlomiassaf commented 7 years ago

When trying to upgrade angular2-webpack-starter (PR AngularClass/angular2-webpack-starter#1297) to istanbul-instrumenter-loader@1.2.0 there's a strange bug...

It happens when using a specific angular configuration to set an import in an NgModule.

When doing so the test breaks, removing istanbul-instrumenter-loader (or reverting back to 0.2.0) removes the issue.

To me it smells like the metadata, the loader might remove some of the metadata of a type when it's not directly used.. I don't know :)

To reproduce clone the repo then update to 1.2.0 and add the code in AngularClass/angular2-webpack-starter#1309

You can look at the issue for some more information.

I'm sorry for lack of information, this is an area i'm not the best in...

mattlewis92 commented 7 years ago

It looks like that starter has been upgraded to the latest version of this loader so I think this can be closed now 😄