search

webpack-contrib / istanbul-instrumenter-loader

Istanbul Instrumenter Loader
MIT License
273 stars 65 forks source link

license? #39

Closed chrisjlee closed 7 years ago

chrisjlee commented 7 years ago

WTFPL. lol

So is there a real license agreement to this? I'm trying to get this package approved for usage and our legal team will probably have a fit about it.

I can PR and update your license if you require.

deepsweet commented 7 years ago

sure, I can change it to MIT. should it be a major version bump? 🤔 May sound like "breaking" changes for someone.

chrisjlee commented 7 years ago

No probably not a breaking change. I guess technically a patch version?

filipesilva commented 7 years ago

Heya, I'm in a similar position myself. Over at https://github.com/angular/angular-cli we're trying to get legal approval but WTFL is a no go. MIT would work for us as well.

According to the discussion at https://github.com/mojombo/semver/issues/322 it sounds like a license change should be a major version, yes.

deepsweet commented 7 years ago

ok, it will be a major change. sorry for delay, have almost no time for open source now.

filipesilva commented 7 years ago

@deepsweet I can put the PR together, would that help?

deepsweet commented 7 years ago

yeah, take it from here please, but starting with 2017 year.

filipesilva commented 7 years ago

Here it is: https://github.com/deepsweet/istanbul-instrumenter-loader/pull/43 LMK if you also want me to bump the version in the PR.

Cheers!