search

webpack-contrib / istanbul-instrumenter-loader

Istanbul Instrumenter Loader
MIT License
273 stars 65 forks source link

Fix loader-utils warning #47

Closed dpogue closed 7 years ago

dpogue commented 7 years ago

Update to loader-utils v1.0 and change the call from parseQuery to getOptions

Context here: https://github.com/webpack/loader-utils/issues/56

DanielaValero commented 7 years ago

Hello @deepsweet

Did you have time to review this? Do you have an estimate date when this will be able to be merged and published?

deepsweet commented 7 years ago

Hi.

It should be fixed soon https://github.com/webpack-contrib/istanbul-instrumenter-loader/tree/d3viant0ne-DefaultsUpgrade as a part of moving to webpack-contrib org.

joshwiens commented 7 years ago

@DanielaValero - loader-utils upgrade enforces NodeJS > 4.3 and requires a semver Major not minor

It will be a part of the webpack-defaults upgrade as to not release back to back majors and should be out to npm later today.

DanielaValero commented 7 years ago

Awesome guys! Thanks a lot for the quick replies

michael-ciniawsky commented 7 years ago

Superseded by #61 Thx :)