refactor: upgrade to webpack-defaults

joshwiens commented 7 years ago

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Updates loader-utils to version 1.1.0
Drops object-assign pollyfill
Adds contrib standard Babel configuration
Adds contrib standard Eslint configuration
Refactors to utilize ES6+ JavaScript features
Adds a commonjs proxy for "main": "dist/cjs.js" to account for ES module .default

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

As a part of the webpack-defaults upgrade a NodeJS version of 4.3 or newer is enforced. "engines": { "node": ">= 4.3 < 5.0.0 || >= 5.10" },
The loader-utils package has also been updated to ^1.1.0 which also requires NodeJS > 4.3

Other information:

Merge & release as a semver: MAJOR with the proper breaking change notations in the squash commits footer.

Publish as 3.0.0 on the beta dist-tag

Closes #53

joshwiens commented 7 years ago

Note: Before this merges, I need to do a quick sanity check in a few consuming projects.

joshwiens commented 7 years ago

@bebraw - Last line in the initial pull request comment :)

bebraw commented 7 years ago

Ah, ok. Netcraft confirms it. 👍

joshwiens commented 7 years ago

This bricks @angular/cli in it's current state and will require an upgrade path and/or a pull request to the cli as a part of this going from beta to latest on the dist-tag.

DanielaValero commented 7 years ago

Hello @d3viant0ne

Is there anything I can pick up here to help getting the PR finalised?

joshwiens commented 7 years ago

Not at the moment. There was a hold on the defaults upgrades while we figured out the best way to setup the Jest suites to execute tests through webpack without sacrificing Jest features

DanielaValero commented 7 years ago

Sure, I'll remain close, in case there is even a dot I can write to help with :)

joshwiens commented 7 years ago

@filipesilva - Friendly heads up, there is a semver Major coming for istanbul-instrumenter-loader. No changes in functionality or the loaders API.

It applies webpack-defaults which in turn enforces the standard webpack versions for engines with the bottom limit being NodeJS 4.3. So Major for the loader, no change for @angular/cli.

I'll push it out on a beta dist-tag and run it through it's paces. Once we are satisfied with it, i'll ping you again incase you want to run it in dev before 3.0.0 goes to @latest

filipesilva commented 7 years ago

@d3viant0ne thanks for the heads up! I can test the new version in Angular CLI once there's a npm tag up that I can use.

joshwiens commented 7 years ago

@michael-ciniawsky - Yeah, holding off on this until we decide on the npm changes & push those out in defaults.

webpack-contrib / istanbul-instrumenter-loader

refactor: upgrade to webpack-defaults #51