Closed michael-ciniawsky closed 6 years ago
Good idea! This is semver major btw as the loader will throw on invalid options now: https://github.com/webpack-contrib/schema-utils/blob/master/src/validateOptions.js#L20
You're right but luckily v3.0.0
is in beta
atm π
What about sourceMapUrlCallback?
It's a {Function}
which isn't directly supported by ajv
(JSON Schema) and I hadn't the time to look into a custom extension to support this type in schema-utils
yet, but it is highly needed :). additionalProperties: true
is the workaround meanwhile π
Fair enough π
@michael-ciniawsky can you rebase this on master? π Also might be worth adding a test that it throws on an invalid option type.
Merging #65 into master will increase coverage by
1.39%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
+ Coverage 90.9% 92.3% +1.39%
=========================================
Files 2 2
Lines 11 13 +2
Branches 2 2
=========================================
+ Hits 10 12 +2
Misses 1 1
Impacted Files | Coverage Ξ | |
---|---|---|
src/index.js | 91.66% <100%> (+1.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 4525107...e516db6. Read the comment docs.
Merging #65 into master will increase coverage by
1.39%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
+ Coverage 90.9% 92.3% +1.39%
=========================================
Files 2 2
Lines 11 13 +2
Branches 2 2
=========================================
+ Hits 10 12 +2
Misses 1 1
Impacted Files | Coverage Ξ | |
---|---|---|
src/index.js | 91.66% <100%> (+1.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 4525107...678a8d0. Read the comment docs.
~Blocked by #63~