search

webpack-contrib / istanbul-instrumenter-loader

Istanbul Instrumenter Loader
MIT License
273 stars 65 forks source link

fix(index): correct loader sourcemaps usage #67

Closed mattlewis92 closed 6 years ago

mattlewis92 commented 6 years ago

I was wrong about the sourcemap behaviour, turns out webpack does actually pass the sourcemap as the second arg to loaders, this PR restores the previous behaviour (with a perf boost by not trying to parse for an inline sourcemap if there is already a source map available)

Depends on https://github.com/webpack-contrib/istanbul-instrumenter-loader/pull/66

codecov[bot] commented 6 years ago

Codecov Report

Merging #67 into master will decrease coverage by 9.09%. The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #67     +/-   ##
========================================
- Coverage     100%   90.9%   -9.1%     
========================================
  Files           2       2             
  Lines           6      11      +5     
  Branches        0       2      +2     
========================================
+ Hits            6      10      +4     
- Misses          0       1      +1
Impacted Files Coverage Δ
src/index.js 90% <83.33%> (-10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0cf823...d8c2740. Read the comment docs.

joshwiens commented 6 years ago

@mattlewis92 - Just landed #66

I'll take a look at appveyor and figure out why it's not reporting.

mattlewis92 commented 6 years ago

@d3viant0ne done!

mattlewis92 commented 6 years ago

Thanks @d3viant0ne 😄 Gave the RC a spin in our app and its all working smoothly now. We probably want to land https://github.com/webpack-contrib/istanbul-instrumenter-loader/pull/65 before cutting 3.0.0 final, as that PR is breaking.