webpack-contrib / istanbul-instrumenter-loader

Istanbul Instrumenter Loader

MIT License

273 stars 65 forks source link

fix(index): merge `input` and `instrumented` sourcemaps #87

Closed filipesilva closed 2 weeks ago

filipesilva commented 5 years ago

Based on the work by @adamburgess in https://github.com/webpack-contrib/istanbul-instrumenter-loader/issues/73#issuecomment-427665948.

Added a minimal update to work with the latest webpack (used in CI tests), updated a dependency with a security issue,, fixed a test, and added a fix for the sourcemaps file names.

Type

[x] Bug

Issues

Fixes #73

SemVer

[x] Patch

codecov[bot] commented 5 years ago

Codecov Report

Merging #87 into master will increase coverage by 1.80%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   92.30%   94.11%   +1.80%     
==========================================
  Files           2        2              
  Lines          13       17       +4     
  Branches        2        3       +1     
==========================================
+ Hits           12       16       +4     
  Misses          1        1

Impacted Files	Coverage Δ
src/index.js	`93.75% <100.00%> (+2.08%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe5fedb...041bcaa. Read the comment docs.

filipesilva commented 5 years ago

Heya @michael-ciniawsky, any update on when this might be merged/released?

L2jLiga commented 5 years ago

@d3viant0ne, @michael-ciniawsky any updates on this?

JamesMessinger commented 5 years ago

I created a new npm package named coverage-istanbul-loader. It includes the fix mentioned above as well as other fixes and updated dependencies.

L2jLiga commented 5 years ago

Hey, @filipesilva, Why to not to use coverage-instanbul-loader? In my point of vision it's great way to get code coverage. Either way Angular pin all dependencies.

(just I'm happened with broken test after migration to Angular 8 and sourcemap is really broken :( )