webpack-contrib / jshint-loader

[DEPRECATED] jshint loader for webpack, please migrate on `eslint`
MIT License
67 stars 37 forks source link

Not reading my .jshintrc #13

Closed kentcdodds closed 9 years ago

kentcdodds commented 9 years ago

I'm not sure what changed, but webpack seems to not be applying my .jshintrc anymore. When I change my .jshintrc to end with .json and require it in my webpack config on the jshint property, everything works as expected.

unindented commented 9 years ago

@sokra This is caused by this commit in rcloader: https://github.com/spenceralger/rcloader/commit/355d6e771553c72b715f7df5d6259f6818cc987f

I've got the same problem in my loader https://github.com/unindented/jscs-loader. How do you want to handle this?

sokra commented 9 years ago

Can we change it to this?

var rcLoader = new RcLoader(".jshintrc", null, {
    loader: function(path) {
        return { path: path };
    }
});
unindented commented 9 years ago

Yep, that should work fine. Do you want to wait until the owner of rcloader chimes in the discussion?

dashed commented 9 years ago

If at all possible, for now, do workaround at jshint-loader and related plugins Otherwise, rcloader would be blocking.

This may not be a trivial fix on rcloader's end.

yordis commented 9 years ago

@unindented any update on this ticket. Is fixed?

sokra commented 9 years ago

I think so.

dashed commented 9 years ago

Might want to consider this: https://github.com/spalger/rcloader/pull/3#commitcomment-9640184