Closed VieZhong closed 1 year ago
I have pushed a commit to fix test case errors. Please approve again! Thx.
Patch and project coverage have no change.
Comparison is base (
cab796f
) 90.37% compared to head (9e6409d
) 90.37%.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
OLD API tests are failing, can you check?
OLD API tests are failing, can you check?
I missed testing the old API. And Now I fixed it. Please review the code again.
@alexander-akait @snitin315
Do you have the access to merge? Please merge and plubish a new version. Thank you all.
Thank you
This PR contains a:
Motivation / Use-Case
i
is a Link tag. But when it loads error, it's parentNode is null. So it will throw an error.Here is the fix , just like what Alexander does in hmr.![image](https://user-images.githubusercontent.com/16253049/218684225-e639d57a-9a7c-413d-92c0-6c10521eb94c.png)
Breaking Changes
Additional Info
see this issuse: https://github.com/webpack-contrib/mini-css-extract-plugin/issues/1017