search

webpack-contrib / mini-css-extract-plugin

Lightweight CSS extraction plugin
MIT License
4.67k stars 388 forks source link

chore: replace deprecated String.prototype.substr() #921

Closed CommanderRoot closed 2 years ago

CommanderRoot commented 2 years ago

This PR contains a:

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

codecov[bot] commented 2 years ago

Codecov Report

Merging #921 (9383ebb) into master (3fd5e5e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files           5        5           
  Lines         828      828           
  Branches      221      221           
=======================================
  Hits          748      748           
  Misses         70       70           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fd5e5e...9383ebb. Read the comment docs.