search

webpack-contrib / mini-css-extract-plugin

Lightweight CSS extraction plugin
MIT License
4.67k stars 388 forks source link

docs: fix runtime value #952

Closed ersachin3112 closed 2 years ago

ersachin3112 commented 2 years ago

This PR contains a:

Motivation / Use-Case

fix runtime value

Fix https://github.com/webpack-contrib/mini-css-extract-plugin/pull/929

Breaking Changes

No

Additional Info

No

codecov[bot] commented 2 years ago

Codecov Report

Merging #952 (0804929) into master (7f72caf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files           5        5           
  Lines         828      828           
  Branches      221      221           
=======================================
  Hits          748      748           
  Misses         70       70           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f72caf...0804929. Read the comment docs.

vsn4ik commented 2 years ago

@alexander-akait what was the problem with merge my PR (#929) that was proposed over two months ago?

alexander-akait commented 2 years ago

@vsn4ik We have failed CI and I missed your commit eventually

vsn4ik commented 2 years ago

@alexander-akait Such situations discourage the desire to participate in product improvement

alexander-akait commented 2 years ago

@vsn4ik sorry, I get a lot of issues/PRs every day (around 80-150+), so I can miss somethings, you can always ping me using my nickname (i.e. ping @alexander-akait)