webpack-contrib / mini-css-extract-plugin

Lightweight CSS extraction plugin
MIT License
4.67k stars 388 forks source link

Update README.md to reflect css-modules #980

Closed justin808 closed 2 years ago

justin808 commented 2 years ago

This PR contains a:

Motivation / Use-Case

Breaking Changes

Additional Info

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

justin808 commented 2 years ago

@pulkitkkr and I have been spending hours trying to debug why we get errors on ordering when splitting chunks.

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?

codecov[bot] commented 2 years ago

Codecov Report

Base: 90.34% // Head: 90.34% // No change to project coverage :thumbsup:

Coverage data is based on head (7c63f81) compared to base (6b1f18a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #980 +/- ## ======================================= Coverage 90.34% 90.34% ======================================= Files 5 5 Lines 829 829 Branches 221 221 ======================================= Hits 749 749 Misses 70 70 Partials 10 10 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webpack-contrib)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alexander-akait commented 2 years ago

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?

That is not safe :disappointed: So we should warning about it

justin808 commented 2 years ago

What's left to get this merged?

alexander-akait commented 2 years ago

Thank you

justin808 commented 2 years ago

Maybe the code should be updated to never worry about the ordering for CSS-modules automatically? That is not safe 😞 So we should warning about it

Is that the case where one is mixing some CSS modules and global CSS?

alexander-akait commented 2 years ago

I recommend to avoid it, except global styles like fonts/animations/counter styles/etc

justin808 commented 2 years ago

I recommend to avoid it, except global styles like fonts/animations/counter styles/etc

What is "it" to avoid? mixing both modules and non-modules?

BTW, we owns https://github.com/shakacode/sass-resources-loader which allows global variables to be used within sass modules.

alexander-akait commented 2 years ago

What is "it" to avoid? mixing both modules and non-modules?

Yes, except global styels for all application, otherwise you need manually to check an order in many places