Closed justin808 closed 2 years ago
@pulkitkkr and I have been spending hours trying to debug why we get errors on ordering when splitting chunks.
Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?
Base: 90.34% // Head: 90.34% // No change to project coverage :thumbsup:
Coverage data is based on head (
7c63f81
) compared to base (6b1f18a
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Maybe the code should be updated to never worry about the ordering for CSS-modules automatically?
That is not safe :disappointed: So we should warning about it
What's left to get this merged?
Thank you
Maybe the code should be updated to never worry about the ordering for CSS-modules automatically? That is not safe 😞 So we should warning about it
Is that the case where one is mixing some CSS modules and global CSS?
I recommend to avoid it, except global styles like fonts/animations/counter styles/etc
I recommend to avoid it, except global styles like fonts/animations/counter styles/etc
What is "it" to avoid? mixing both modules and non-modules?
BTW, we owns https://github.com/shakacode/sass-resources-loader which allows global variables to be used within sass modules.
What is "it" to avoid? mixing both modules and non-modules?
Yes, except global styels for all application, otherwise you need manually to check an order in many places
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info