webpack-contrib / organization

Applications, Standards & Documentation for webpack-contrib.
14 stars 10 forks source link

Ensure all contrib repositories have `engines` defined #7

Closed joshwiens closed 6 years ago

joshwiens commented 7 years ago

We have more than a few repos that don't have the engines field designated in the package.json

  "engines": {
    "node": ">=4.3.0 <5.0.0 || >=5.10"
  },
sapegin commented 7 years ago

Any reason to skip 5.0—5.9? I’ve sent a PR to webpack-defaults.

joshwiens commented 7 years ago

There is a reason for it based on issues with those versions & webpack. I don't know what they are exactly, only that they exist.

sapegin commented 7 years ago

OK, I’ll add a comment in webpack-defaults then ;-)

sukrosono commented 7 years ago

I would suggest a done-list on first post, so we can track remaining work and it's progress.

joshwiens commented 7 years ago

Engines ranges come with webpack-defaults. Which is trackable here https://github.com/orgs/webpack-contrib/projects/5

sukrosono commented 7 years ago

it lead me 404, it's restricted scope? Nvm if you already have the checklist :smile: .

joshwiens commented 7 years ago

Organization project so probably but none the less, there is tracking across every project under contrib

michael-ciniawsky commented 6 years ago

Resolved by/in webpack-defaults