fix: do not crash if pkg.(d|devD)ependencies unset

webpack-contrib / postcss-loader

PostCSS loader for webpack

MIT License

2.86k stars 211 forks source link

fix: do not crash if pkg.(d|devD)ependencies unset #667

Closed mcous closed 8 months ago

mcous commented 11 months ago

This PR contains a:

[x] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case

Fixes #547. dependencies and devDependencies are not required fields of package.json, but the existing code assumes they are always present, which can throw an uncaught error.

Breaking Changes

N/A

Additional Info

I no longer use this library, but I got tired of my stale ticket sitting around in my issues list 😜

linux-foundation-easycla[bot] commented 11 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: mcous / name: Michael Cousins (e71c85eb474e1d93472c8bdd91a294c31ff34a54)
:white_check_mark: login: alexander-akait / name: Alexander Akait (ee0c90fd417d23f1c24a71eb864ac0c50bd15bb6)

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (84f16be) 88.70% compared to head (ee0c90f) 88.73%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #667 +/- ## ========================================== + Coverage 88.70% 88.73% +0.03% ========================================== Files 3 3 Lines 354 355 +1 Branches 115 116 +1 ========================================== + Hits 314 315 +1 Misses 37 37 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.