webpack-contrib / purifycss-webpack

UNMAINTAINED, use https://github.com/FullHuman/purgecss-webpack-plugin
MIT License
772 stars 37 forks source link

feat - Add strict validation against `paths` #88

Closed johakr closed 7 years ago

johakr commented 7 years ago

I am not sure which kind of error handling might be appropriate for this case, though. I decided to throw an error, but we might consider to remove the non existing path(s), build anyway and show a warning message.

77

jsf-clabot commented 7 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 7 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.03%. The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   66.21%   66.25%   +0.03%     
==========================================
  Files           5        5              
  Lines          74       80       +6     
  Branches       22       25       +3     
==========================================
+ Hits           49       53       +4     
- Misses         25       27       +2
Impacted Files Coverage Δ
src/index.js 0% <0%> (ø) :white_check_mark:
src/parse.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6688188...30b8f31. Read the comment docs.

bebraw commented 7 years ago

Could you add a unit test against flatten? Good to go after that.

Failing hard (error) is fine. Easier to catch problems that way.

johakr commented 7 years ago

Good point, just added the unit test. 😄

bebraw commented 7 years ago

Thanks. Included in 0.5.0.

If you have time, have a look at the open issues. There's some debugging to do. It would be good to understand where those problems originate from (the plugin or purify).