webpack-contrib / purifycss-webpack

UNMAINTAINED, use https://github.com/FullHuman/purgecss-webpack-plugin
MIT License
772 stars 37 forks source link

Build process not finish #95

Open Kikobeats opened 7 years ago

Kikobeats commented 7 years ago

I don't know why, but nowadays my webpack don't finish after ~10 mins:

90% recording

I don't have too many components and, If I avoid Purify section from the production build all works fine.

My Purify configuration, as you suggested, is this.

Can I do something for debug the problem? Build is running with webpack ---debug flag but nothing happens.

PS: Now I run the build using purifycss-webpack@0.4.0 and works fine 🤔

bebraw commented 7 years ago

Hi,

There's not enough information to say anything conclusive. I would need a tiny project to look at. Maybe setting verbose would give some insight. One option is that it's Purify that hangs and that's something we can't fix at the plugin.

Kikobeats commented 7 years ago

@bebraw one question, the order of the webpack plugins, is it important?

Reproduce case is:

git clone git@github.com:windtoday/windtoday-marketplace.git
npm install && npm run build

Sorry If I don't have more information, I'm trying to understand what happens

bebraw commented 7 years ago

Yeah, the plugin has to be after ExtractTextPlugin.

I'll check the repo. Thanks.

bebraw commented 7 years ago

Yup, confirmed.

The build could stall if it never gets to the callback at https://github.com/webpack-contrib/purifycss-webpack/blob/3b04e3180a6b776e801708e3e608c38a09a3d6b0/src/index.js#L80 . I don't understand how that's possible, though.

I guess the next step would be reducing the example as much as possible to pinpoint the cause.

Kikobeats commented 7 years ago

Using purifycss-webpack@0.4.0 looks like cb is called, but unused styled are not remove 🤔 .

Any important change in the implementation between 0.4.0 and 0.5.0 ?

bebraw commented 7 years ago

Here, https://github.com/webpack-contrib/purifycss-webpack/compare/v0.4.0...v0.5.0#diff-1fdf421c05c1140f6d71444ea2b27638 . It does a lookup little differently.